Fix FEED_MIRROR URL by adding trailing slash #5402
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes insecure downgrade to http-only: curl -I https://mirror.cveb.in/nvd/json/cve/1.1 HTTP/1.1 301 Moved Permanently server: nginx/1.28.0 date: Tue, 21 Oct 2025 08:25:02 GMT content-type: text/html content-length: 169 location: http://mirror.cveb.in/nvd/json/cve/1.1/ vs. curl -I https://mirror.cveb.in/nvd/json/cve/1.1/ HTTP/1.1 200 OK server: nginx/1.28.0 date: Tue, 21 Oct 2025 08:24:54 GMT content-type: text/html
|
While this change does indeed seem to work, I wonder if correcting the mirror config would be a better solution. @warthog9, what do you think? |
https in this case literally provides nothing useful and slows the entire file distribution down a fair bit |
|
That being said the '/' at the end does look like it resolves things more correctly, though so it's mostly a non-issue |
|
The redirects should also be fixed in the backend now |
|
Yeah can confirm, the backend is fixed now: Therefore I am closing this PR now, not needed anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes insecure downgrade to http-only:
curl -I https://mirror.cveb.in/nvd/json/cve/1.1
HTTP/1.1 301 Moved Permanently
server: nginx/1.28.0
date: Tue, 21 Oct 2025 08:25:02 GMT
content-type: text/html
content-length: 169
location: http://mirror.cveb.in/nvd/json/cve/1.1/
vs.
curl -I https://mirror.cveb.in/nvd/json/cve/1.1/
HTTP/1.1 200 OK
server: nginx/1.28.0
date: Tue, 21 Oct 2025 08:24:54 GMT
content-type: text/html